Update custom patterns label to 'My patterns' #51949
Merged
+52
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +66 B (0%) Total Size: 1.45 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Nice work @SaxonF 👍
I like the new position of the "My Patterns" category. It still seems a bit odd that patterns created by different users would all appear under that single "My Patterns" category but I also agree that the implied ownership could be a positive as well.
The only issue I encountered while testing was the "empty state".
If the user hasn't created any patterns, we still default to the "My Patterns" category and display nothing. Perhaps we should fall back to the header category when there aren't any custom patterns?
This was referenced Jun 27, 2023
carolinan
added
[Type] Enhancement
We can partially address this by displaying the original author in the pattern details panel.
I think that makes sense. The 'Custom patterns' section is hidden on trunk so it would be consistent. A nicely designed empty state explaining how to use patterns might be nice to explore as a follow-up. |
Agreed. I don't think this is a blocker. Perhaps following up with a filter defaulting to patterns created by you, but you can opt to display those created by all authors as well. |
Yea, that's fine. Worth a follow-up to set default type and category based on if custom patterns do exist. |
richtabor
approved these changes
Jun 27, 2023
talldan
force-pushed
the
update/custom-patterns-label
branch
from
7211b55
to
6824694
Compare
|
There were some conflicts with this and #51947, I've rebased and tried to solve them. It might be worth testing again to see if I missed anything. |
There was a problem hiding this comment.
It might be worth testing again to see if I missed anything.
I've given this another quick test.
✅ Custom patterns renamed to my patterns
✅ Library now defaults to my patterns category
✅ Inserter reflects the category name change as well
Doesn't look to me like anything regressed after the rebase.
talldan
force-pushed
the
update/custom-patterns-label
branch
from
6824694
to
97ffc57
Compare
|
There was another conflict so rebased and resolved again 😄 |
talldan
changed the title
talldan
reviewed
Jun 28, 2023
| @@ -14,7 +14,7 @@ import { store as blockEditorStore } from '../../../store'; | |||
|
|
|||
| const CUSTOM_CATEGORY = { | |||
| name: 'custom', | |||
| label: __( 'Custom patterns' ), | |||
| label: __( 'My patterns' ), | |||
| description: __( 'Custom patterns add by site users' ), | |||
There was a problem hiding this comment.
Might need to double-check this description.
|
Flaky tests detected in 97ffc57. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5400009432
|
aaronrobertshaw
added
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Jul 3, 2023
* rename custom patterns to my patterns * Add my patterns label to inserter and show at the top --------- Co-authored-by: Daniel Richards <[email protected]>
|
I just cherry-picked this PR to the update/wp6-3-beta3 branch to get it included in the next release: d45c58c |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
added a commit
that referenced
this pull request
Jul 3, 2023
* Footnotes: inscrease selector specificity for anchor (#52179) * Patterns: Include template parts for custom areas in Uncategorized category (#52159) * Fix custom patterns console error (#51947) * Fix error with react list key with new custom patterns list in inserter * Update placeholder key * Add comment to explain the different keys * Patterns: Fix missing custom patterns in patterns explorer (#51889) * Add custom patterns to pattern explorer * show custom patterns in the patterns explorer dialog * remove changes from 51877 * Fix up use of async lists * remove a bit of code duplication by adding a new hook * add 51877 fix back to make testing easier * Just assign the key value in one place * Refactor the custom patterns to use the usePatternsState hook * Fix use of async list * Translate strings and remove unneeded fields from pattern object * Try integrating unsynced patterns directly into pattern selectors (#51955) * Include reusable blocks with an undefined sync status in inserter items * Update docs * Remove change to hover dependencies --------- Co-authored-by: Daniel Richards <[email protected]> * i18n: Add context to the word "Filters" (#52198) * Update home template icon (#52075) * Centralise all permissions lookup in Link UI and enable (#52166) * BlockRemovalWarningModal: Fix incorrect '_n' usage (#52164) * Fix fetching Nav fallback ID flushing Navigation entity cache (#52069) * Only flush the `getEntityRecords` cache if the fallback isn’t already in state * Save the edited entity record to a const and then invert it to determine whether we should invalidate the recordds --------- Co-authored-by: scruffian <[email protected]> * Block Editor: Unify texts for Create pattern modal (#52151) * Fix history back after entering edit mode from Patterns (#52112) * Add template part icons to the library grid items (#51963) * Patterns: Fix sidebar tab label (#51953) * Patterns: Fix setting of sync status for fully synced patterns (#51952) * Library: Reinstate manage all template parts page (#51961) * Command Palette: fix incorrect path and snackbar message when template part is deleted (#52034) * Command Center: Fix incorrect navigation when deleting template part * removeTemplate: consider title type * Drop-indicator: remove white border. (#52122) * Make Navigation fallback selector private (#51413) * Move selector to become private * adds basic lock functionality * remove useless lock-unlock file * map private selectors to resolvers * Unlock the other usage * only create one fallback per session * Fix core-data duplicate private opt-in * Data: bind resolvers to selectors individually, support private selectors --------- Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> * Focus Mode: Use the symbol icon if a pattern is being edited (#52031) * Footnotes: register meta field for pages (#52024) * Fix unintentional toggling on of distraction free (#52090) * replace toggle with set preference - because I don't read code properly it seems * remove notification * Revert "Updating social link attributes (#51997)" (#52019) This reverts commit c711e2a. * Update home template name (#52048) * Removes unused call (#51988) * Remove ability for user to toggle sync status after pattern creation (#51998) * Fix disable DFM when opening styles command (#52165) * Update custom patterns label to 'My patterns' (#51949) * rename custom patterns to my patterns * Add my patterns label to inserter and show at the top --------- Co-authored-by: Daniel Richards <[email protected]> * Library: Add sync status to pattern details screen (#51954) * Patterns: Rename Library to Patterns (#52102) * [Library] Add lock icon for theme patterns (#51990) * Add lock icon for theme patterns * Change to class names * Add aria-description * Change wording * Patterns: Use "detached" copy consistently (#51993) * Editor initrial appender: Zero out margins in constrained layouts. (#52026) * Update pattern creation modal in library (#51946) * Fix missing snackbars in Library (#52021) * Make the entire preview clickable in order to enter "edit" mode in focus mode (#51973) * Page Content Focus: Add welcome guides (#52014) * Page Content Focus: Add welcome guides * Don't show when editor guide is active * Just use regular accent/theme color in all guides * slight copy change page guide * Update components changelog * Disable new guides in E2E tests * Use s.w.org videos --------- Co-authored-by: Saxon Fletcher <[email protected]> --------- Co-authored-by: Ella <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: Joen A <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Rich Tabor <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
17 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* rename custom patterns to my patterns * Add my patterns label to inserter and show at the top --------- Co-authored-by: Daniel Richards <[email protected]>
38 tasks
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51939
Fixes #51943
Renames "custom patterns" to "my patterns" and repositions it to the top of the list in library and inserter.
Why?
Resolves:
Testing Instructions